-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Search for & upload .conda
packages
#37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one suggestion for your consideration.
ci/gpuci/run.sh
Outdated
anaconda -t ${MY_UPLOAD_KEY} upload -u ${CONDA_USERNAME:-gpuci} --label main --skip-existing \ | ||
/opt/conda/conda-bld/${ARCH_DIR}/gpuci-tools*.conda \ | ||
/opt/conda/conda-bld/${ARCH_DIR}/gpuci-tools*.tar.bz2 \ | ||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anaconda -t ${MY_UPLOAD_KEY} upload -u ${CONDA_USERNAME:-gpuci} --label main --skip-existing \ | |
/opt/conda/conda-bld/${ARCH_DIR}/gpuci-tools*.conda \ | |
/opt/conda/conda-bld/${ARCH_DIR}/gpuci-tools*.tar.bz2 \ | |
; | |
anaconda -t ${MY_UPLOAD_KEY} upload -u ${CONDA_USERNAME:-gpuci} --label main --skip-existing /opt/conda/conda-bld/${ARCH_DIR}/gpuci-tools*.{conda, tar.bz2} |
Think it'd be a bit simpler to just use {option1,option2}
instead of repeating the search directory twice.
I'd still support breaking that onto another line if you want, but don't feel as strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly was thinking of replacing this by find
as currently shellcheck
doesn't like the lack of quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fine too, whatever works 🤷🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was just CI was failing due to shellcheck
. So that also needed to be addressed
Though do appreciate the tip
Please let me know what you think of the rewrite
* Match other upload scripts with `find` * Do a single pass of the files * Write in a `shellcheck` conformant way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you!
After talking with Ray offline, it sounds like this repo is scheduled for archival. So we don't need this PR |
To ensure there are no more references to the script changed in this PR, searched the org specifically for
So there are no other references to Meaning we don’t need this PR. So am closing it out |
Part of issue: rapidsai/build-planning#98
find
's-o
option to search for.conda
or.tar.bz2
files to upload.conda
glob toanaconda upload
command