Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build C++ wheel #4340

Draft
wants to merge 67 commits into
base: branch-24.12
Choose a base branch
from
Draft

Build C++ wheel #4340

wants to merge 67 commits into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 12, 2024

This PR changes wheel building in RMM to create a separate C++ wheel that is then found from the Python wheel. The C++ wheel is now a hard dependency of the Python wheel. This allows Python packaging to more closely mirror the structure of our conda packaging, and the way we would normally wish to package these in any other manager. It also allows us to reduce package sizes by allowing better sharing of artifacts between different Python packages that rely on the same C++ components from other packages.

Contributes to rapidsai/build-planning#33

@vyasr vyasr added the Epic Tracker for a relatively large body of work that is broken down into stories and issues label May 9, 2024
@BradReesWork BradReesWork changed the base branch from branch-24.06 to branch-24.08 May 28, 2024 13:10
@BradReesWork BradReesWork added this to the 24.08 milestone May 28, 2024
@KyleFromNVIDIA
Copy link
Contributor

Please open a PR at https://github.com/rapidsai/rapids-metadata to reflect the new project structure. This can be the same PR as the one that updates cudf.

# Iterate over the array
for wheelhouse in "${WHEELHOUSES[@]}"; do
FIND_LINKS+="--find-links ${wheelhouse} "
done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we pick this back up, I think it'd be preferable to switch away from FIND_LINKS towards a constraint file, as described in rapidsai/build-planning#69 (comment).

@BradReesWork BradReesWork modified the milestones: 24.08, 24.10 Aug 5, 2024
@BradReesWork BradReesWork changed the base branch from branch-24.08 to branch-24.10 August 5, 2024 19:22
@BradReesWork BradReesWork changed the base branch from branch-24.10 to branch-24.12 September 30, 2024 13:52
@BradReesWork BradReesWork modified the milestones: 24.10, 24.12 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake Epic Tracker for a relatively large body of work that is broken down into stories and issues feature request New feature or request non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants