Reorganize cudf_polars expression code
#17014
Conversation
brandon-b-miller
added
feature request
| from polars.polars import _expr_nodes as pl_expr | ||
|
|
||
| from cudf_polars.containers import Column, NamedColumn | ||
| from cudf_polars.utils import dtypes, sorting | ||
| from cudf_polars.containers import Column |
There was a problem hiding this comment.
Do we want to keep this file at all?
There was a problem hiding this comment.
Additionally a few of these didn't seem to have an obvious home, maybe a misc.py?
There was a problem hiding this comment.
I think it is useful to have everything importable from one place. So yes, I think it makes sense to keep this file.
I think it would be nice if all this file did was to import the expression names into the dsl.expr namespace.
So moving the remainder makes sense to me.
How about Cast into unary.py, Ternary into ternary.py and BooleanFunction into boolean.py?
There was a problem hiding this comment.
Thanks @brandon-b-miller! This looks like a good step to me. Some small further suggestions.
| from polars.polars import _expr_nodes as pl_expr | ||
|
|
||
| from cudf_polars.containers import Column, NamedColumn | ||
| from cudf_polars.utils import dtypes, sorting | ||
| from cudf_polars.containers import Column |
There was a problem hiding this comment.
I think it is useful to have everything importable from one place. So yes, I think it makes sense to keep this file.
I think it would be nice if all this file did was to import the expression names into the dsl.expr namespace.
So moving the remainder makes sense to me.
How about Cast into unary.py, Ternary into ternary.py and BooleanFunction into boolean.py?
| from collections.abc import Mapping | ||
|
|
||
| from cudf_polars.containers import DataFrame | ||
|
|
There was a problem hiding this comment.
nit: throughout, can we advertise __all__?
This PR seeks to break up
expr.pyinto a less unwieldy monolith.