make conda installs in CI stricter #17013
Open
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
jameslamb
changed the title
jameslamb
changed the title
jameslamb
added
3 - Ready for Review
bdice
approved these changes
Oct 8, 2024
| @@ -5,6 +5,8 @@ set -euo pipefail | |||
|
|
|||
| . /opt/conda/etc/profile.d/conda.sh | |||
|
|
|||
| RAPIDS_VERSION_MAJOR_MINOR="$(rapids-version-major-minor)" | |||
There was a problem hiding this comment.
In build_docs.sh we export this, but here we're just setting it locally. I doubt it matters here but it might be worth establishing consistent patterns. Also applies to other files.
There was a problem hiding this comment.
My thinking here was "export it if it's already exported (as in the docs example), otherwise make it local", since I thought that had the least risk of causing other surprising problems.
I clicked around a little, and I think:
RAPIDS_VERSION= does not even need to be set in docs-build scriptsRAPIDS_VERSION_MAJOR_MINOR= does not need to be exportedRAPIDS_VERSION_NUMBER= needs to be exported, forrapids-upload-docs(code link in gha-tools)
For all the other scripts that are not docs builds, this PR only introduces NEW variables, so I think not exporting them is slightly safer.
Just pushed 16367a5 doing that. If that works, I'll make similar changes in the other PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#106
Proposes specifying the RAPIDS version in
conda installcalls in CI that install CI artifacts, to reduce the risk of CI jobs picking up artifacts from other releases.Checklist