Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on xfail_strict = true for all python packages #16977

Merged
merged 16 commits into from
Oct 8, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Oct 2, 2024

Description

The cudf tests already treat tests that are expected to fail but pass as errors, but at the time we introduced that change, we didn't do the same for the other packages. Do that now, it turns out there are only a few xpassing tests.

While here, it turns out that having multiple different pytest configuration files does not work. pytest.ini takes precedence over other options, and it's "first file wins". Consequently, the merge of #16851 turned off xfail_strict = true (and other options) for many of the subpackages.

To fix this, migrate all pytest configuration into the appropriate section of the pyproject.toml files, so that all tool configuration lives in the same place. We also add a section in the developer guide to document this choice.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested review from a team as code owners October 2, 2024 17:14
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Oct 2, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 2, 2024
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally support consolidating all these settings in pyproject.toml... that mix of pytest.ini and pyproject.toml here has tripped me up in the past too.

Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some optional options to set in a follow-up if interested to make pytest more strict

@wence-
Copy link
Contributor Author

wence- commented Oct 3, 2024

  • --strict-config --strict-markers

I added these, let's see

@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Oct 3, 2024
@wence-
Copy link
Contributor Author

wence- commented Oct 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit cc23474 into rapidsai:branch-24.12 Oct 8, 2024
102 checks passed
@wence- wence- deleted the wence/fix/12391 branch October 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] some pytest configurations not used Turn on xfail_strict=true in all subpackages
5 participants