Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable conda-build to produce .conda packages #176

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakirkham
Copy link
Member

Fixes rapidsai/build-planning#98

Switch from .tar.bz2 packages to .conda packages. This will allow the metadata of packages to be read without decompression. Also .conda packages allow changing the compression used under-the-hood (currently this is Zstd based).

Switch from `.tar.bz2` packages to `.conda` packages. This will allow
the metadata of packages to be read without decompression. Also `.conda`
packages allow changing the compression used under-the-hood (currently
this is Zstd based).
@jakirkham jakirkham requested a review from a team as a code owner August 28, 2024 00:23
@jakirkham jakirkham requested review from bdice and removed request for a team August 28, 2024 00:23
@jakirkham
Copy link
Member Author

Nearly all jobs passed. One failed due to a network error (snippet below)

Channels:
 - conda-forge
Platform: linux-64
Collecting package metadata (repodata.json): ...working... failed

CondaHTTPError: HTTP 000 CONNECTION FAILED for url <https://conda.anaconda.org/conda-forge/noarch/repodata.json>
Elapsed: -

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.
'https//conda.anaconda.org/conda-forge/noarch'

Restarted the failed job

@jameslamb jameslamb self-requested a review August 28, 2024 14:00
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham jakirkham added the DO NOT MERGE Hold off on merging; see PR for details label Aug 29, 2024
@jakirkham
Copy link
Member Author

Adding DO NOT MERGE label while we work through those cases James identified

There are a list of xref'd PRs below James' other comment: rapidsai/build-planning#98 (comment)

Perhaps folks can review these as they are able

@jameslamb
Copy link
Member

Perhaps folks can review these as they are able

Thanks! I just reviewed all of those and did one more GitHub search (link). I think you got all the cases, so once those open PRs are merged (at least the ones in the active repos), I think this PR here in ci-imgs could be merged.

@jakirkham
Copy link
Member Author

Thanks James! 🙏

Appreciate you going through those so quickly. Please let me know if I've missed any feedback that needs addressing

Am noticing the label checker is not enabled here. So the DO NOT MERGE label, doesn't fail CI

To avoid accidental merges before those other items are addressed, will mark this as draft. We can mark it ready for review after

@jakirkham jakirkham marked this pull request as draft August 30, 2024 00:08
@jakirkham
Copy link
Member Author

Think we have cleared all the requirements for this change

Would propose that we add this after 24.10 ships. So leaving as draft for now

Though think we should do this at the start of 24.12 so we have more time to get comfortable with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Hold off on merging; see PR for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Conda packages to .conda (instead of .tar.bz2)
3 participants