WIP: Change RKE2 E2E cluster template registration method + review Short/Full test labels #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch to using control-plane-endpoint Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
added
kind/enhancement
salasberryfin
force-pushed
the
e2e-test-review-rke2-failures
branch
from
cb60e14
to
17d4dc8
Compare
test/e2e/suites/migrate-gitops/migrate_gitops_provv1_mgmtv3_test.go
Outdated
Show resolved
Hide resolved
salasberryfin
force-pushed
the
e2e-test-review-rke2-failures
branch
2 times, most recently
from
0299216
to
3c0d21b
Compare
and move kubeadm test cases to full label Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
e2e-test-review-rke2-failures
branch
from
3c0d21b
to
3cb34fd
Compare
| @@ -29,7 +29,7 @@ import ( | |||
| "github.com/rancher/turtles/test/e2e/specs" | |||
| ) | |||
|
|
|||
| var _ = Describe("[Docker] [Kubeadm] - [management.cattle.io/v3] Create and delete CAPI cluster functionality should work with namespace auto-import", Label(e2e.ShortTestLabel), func() { | |||
| var _ = Describe("[Docker] [RKE2] - [management.cattle.io/v3] Create and delete CAPI cluster functionality should work with namespace auto-import", Label(e2e.ShortTestLabel), func() { | |||
There was a problem hiding this comment.
I know @Danil-Grigorev saw some memory limits issues on the github runner when using RKE2 in a short run
There was a problem hiding this comment.
It's probably what I've seen when testing this. Passed locally but failed remotely. Could this be affecting nightly tests too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Nightly E2E have been reporting failures on a Docker + CAPRKE2 scenario. This changes the registration method to
control-plane-endpointto align with other template, e.g. the one used in CAPRKE2 repository here.Additionally, we're currently running RKE2 tests only when executing E2E with the
FullTestLabellabel enabled. This means, RKE2 scenarios are not validated on new PRs, while we do run Kubeadm-specific tests onShortTestLabellabel. Since Turtles ships with RKE2 only, it is sensible to test CAPRKE2 clusters on short test execution and do the opposite for Kubeadm.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist: