Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply color patch from rtorrent-0.9.6_color.patch #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

myallod
Copy link

@myallod myallod commented Apr 9, 2016

Please add color to rtorrent

@pyroscope
Copy link
Contributor

Even if Jari accepts this, doing it as an array with names or enum indices is way less code and more extensible.

@rakshasa
Copy link
Owner

rakshasa commented Aug 3, 2016

As said, array and enums is a must.

It also needs to have a proper setting to enable/disable colors, and not to mention this should obviously be in command_ui.cc, under the 'ui.foo.bar' command namespace.

I'm all for adding colors if the code is good. (default to off)

@myallod
Copy link
Author

myallod commented Aug 8, 2016

would you please give me a hint about array and enum that needed.

@chros73
Copy link
Contributor

chros73 commented Aug 8, 2016

You can take a look pyroscope's beautiful code in rtorrent-ps : https://github.com/pyroscope/rtorrent-ps/blob/master/patches/ui_pyroscope.cc

@KopfKrieg
Copy link

Just for your information: The "official" colorpatch branch is avaliable in my fork of the repository (including prior versions, that's also the one used in the Arch Linux rtorrent-color AUR package): https://github.com/KopfKrieg/rtorrent/tree/colorpatch

@KopfKrieg
Copy link

Since my C++ skills are very basic and I have trouble porting the v0.9.6 colorpatch to the shortly released v0.9.7: Is there somebody who could help me rewrite the colorpatch so it could officially be added to rtorrent? Including the above mentioned changes to add the code to the command_ui.cc and using enums (and adding an option to disable colors, which should probably be the default?)?

@myallod
Copy link
Author

myallod commented Jun 24, 2018

+1

With lib v0.9.7 i have to rebuild rtorrent without color recently. Seems worse than early with colors.
I do not know cpp and cannot help :(
Only can copy-paste and stackoverflow.

@pyroscope
Copy link
Contributor

pyroscope commented Jun 24, 2018

Look at torrent.list.layout and do something similar for colors – a bool would suffice (ui.colors.enabled), but a string value (ui.colors.theme) would allow different colorization schemes / themes (possibly foregoing variables for different single colors).

Or take my "palette" of functional colors (or parts of it):

… and code scattered around the module using those colors.

@Hund
Copy link

Hund commented Jun 8, 2021

What's the progress of this?

@KopfKrieg
Copy link

KopfKrieg commented Jun 10, 2021

What's the progress of this?

Well, I don't maintain the patch any more, and it doesn't seem like anyone has tried to port it to v0.9.7 yet. So … still the same as 3 years ago, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants