Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #1108

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Minor cleanup #1108

wants to merge 7 commits into from

Conversation

a1346054
Copy link

No description provided.

@rakshasa
Copy link
Owner

Thanks, however I'd rather not do minor syntax cleanup across lots of source files as that makes merging a pain.

@a1346054
Copy link
Author

a1346054 commented Sep 2, 2021

I reworded the commit messages to adhere to the current commit message style in the repository, as well as split them up a bit more to make review easier.

Let me know if there's anything I can do to improve on the commits so that they may be merged. As far as I can tell, there are no merge conflicts currently.

@a1346054
Copy link
Author

Rebased to fix some more spelling issues.

If the commit that removes trailing whitespace is the problem, I can drop it. It doesn't remove all the trailing whitespace from the codebase anyway.

This makes it easier to see what the exact differences are between the
three files, as well as fixes a mix of tabs and spaces.
`which` will print, even if the command does not exist, so the test will
never fail. Additionally, `which` is non-standard, and has been
deprecated by debian. `command -v` is the POSIX-standardized way of
testing for existence of commands, and works the same even on non-POSIX
systems that implement the `command` command.

`command -v` will exit with 0 and print to stdout when the command
exists, and will exit with 1 and *not* print anything to stdout or
stderr when the command does not exist.
The previous file had broken indentation as well as other minor
differences from the file distributed by gnu.org

File downloaded from:
https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
@a1346054
Copy link
Author

I dropped the commit that removes trailing whitespace, and added a few more spelling fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants