Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3266

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Update README.md #3266

merged 1 commit into from
Jan 24, 2022

Conversation

justin808
Copy link
Contributor

No description provided.

@justin808 justin808 requested a review from dhh January 23, 2022 20:34
@guillaumebriday guillaumebriday merged commit 8660628 into rails:master Jan 24, 2022
@justin808 justin808 deleted the patch-28 branch January 25, 2022 01:12
dhh added a commit that referenced this pull request Jan 25, 2022
@dhh
Copy link
Member

dhh commented Jan 25, 2022

I've incorporated some of these changes into 14dcce2. But please ping me before merging any revisions going forward.

@justin808
Copy link
Contributor Author

Hi @dhh, sure thing. With Shakapacker v6 out, we're ready to roll. In fact, we've got a PR for replacing Babel with 10x faster SWC: shakacode/shakapacker#29.

And zero known issues!

I'm working on several projects where Webpacker is really needed and awesome!

@justin808
Copy link
Contributor Author

@dhh in the current text, you have three clear recommendations:

  1. jsbundling-rails
  2. import-maps
  3. old webpacker as-is

Could Shakapacker be included in the recommendations for those that need advanced webpack integration?

My concern is that the community may have concerns with moving to Shakapacker without it being listed in the "recommendations."

@guillaumebriday thoughts?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants