-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix frozen string literal for ruby 3.4 #719
base: main
Are you sure you want to change the base?
Conversation
83ba6c9
to
5797699
Compare
I think I need help, for some reason the vendored JSON library is not called in acceptance tests? and I know for sure it does a string mutation because my application warns ( and crashes because i've monkey patch ruby's |
e322517
to
0a75db3
Compare
@chaadow I think the way to fix this would be to run okjson's tests with frozen string literals enabled, then re-embed it in to Spring. It looks like the upstream repo has been archived though, so I'm not sure who is in charge of this code anymore. |
FWIW I ran the OKJson tests using your patch, and that fixed all of the errors there so I think this change is fine. Can you also add the "frozen string literal" directive to the top of |
02a8a4b
to
daf36d7
Compare
@tenderlove Done! thanks for the review. I do think this vendored JSON is outdated and can be switched with a more recent implementation. The CI is failing, but I can't figure out why in the errors displayed, if you have any tips please let me know. I'll keep trying to investigate when I got more time. |
@tenderlove Based on this ( #713) the PR was merged even though the CI was failing. and the CI errors are similar to here. So maybe, if you don't mind, we can merge this PR and repair CI in another PR? |
c1d39e9
to
9680201
Compare
After running
RUBYOPT='--enable-frozen-string-literal --debug-frozen-string-literal' bin/rails c
( Following this guide )I had this issue:
I went ahead and updated github actions as well, inspired by this svenfuchs/rails-i18n#1120