Add compatibility with strict_loading_by_default #375
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rails#122 Allow an app to run in strict_loading_by_default mode by explicitly turning off strict loading on all solid queue models.
JoeDupuis
changed the title
JoeDupuis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
Allows the app to run in
strict_loading_by_defaultmode by explicitly turning off strict loading on all Solid Queue models.Also enables
strict_loading_by_defaulton the dummy app to prevent strict loading issues from being introduced.Alternative / strict_loading enabled
I tried to support strict_loading instead of turning it off, but after spending time on it, I don't think it's worth it. It is a little bit faster, but bring a bunch of complexity.
I opened a draft PR on my fork to demonstrate what it would look like: JoeDupuis#1
Even if we decide to go down the road of enabling strict_loading in Solid Queue, we should merge this PR first to unblock strict_loading apps while working on the fix.