Delete ready_executions only when they've been claimed #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we try to claim a set of job IDs, creating claimed executions for them, but for some reason, we fail to do that for some of them, in a way that the failure is ignored (eg. on a duplicate key conflict that gets ignored with Rails's `insert_all`), we'd be deleting the ready execution for these, even if they weren't claimed at all, leaving the job in limbo. This change simplifies a bit the claiming code and ensures only those jobs that have been claimed are indeed deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we try to claim a set of job IDs, creating claimed executions for them, but for some reason, we fail to do that for some of them, in a way that the failure is ignored (e.g. on a duplicate key conflict that gets ignored with Rails's
insert_all), we'd be deleting the ready execution for these, even if they weren't claimed at all, leaving the job in limbo. This change simplifies a bit the claiming code and ensures only those jobs that have been claimed are indeed deleted.This also adds
NOT NULLconstraints tojob_idcolumns, that I had missed.