fix: Updated check logic for token_stream existence
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the change in ruby/rdoc#1055, `token_stream` returns empty Array instead of `nil`, so update check logic for `token_stream` existence.
The comment says "source_url is also nil", so add a test to cover that case.
spec/helpers_spec.rb
Outdated
Comment on lines
873
to
875
| # Unfortunately, _source_url is also nil because RDoc does not provide the | ||
| # source code location in this case. | ||
| _(source_url).must_be_nil |
There was a problem hiding this comment.
The omission of this assertion is intentional.
The comment acknowledges that source_url is nil, but we wish it was not nil. Therefore, we don't want to assert that it "must be" nil.
There was a problem hiding this comment.
Okay, I've reverted the commit. 👍
This reverts commit 0eedb25.
|
Since ruby/rdoc#1056 has been merged, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the change in ruby/rdoc#1055,
token_streamreturns empty Array instead ofnil,so update check logic for
token_streamexistence.The comment says "source_url is also nil", so add a test to cover that case.