Skip to content

Commit

Permalink
Bump solid_queue for pauses support and enable tests for that again
Browse files Browse the repository at this point in the history
  • Loading branch information
rosa committed Oct 26, 2023
1 parent 2ec4f7a commit 7f4fb35
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ GIT

GIT
remote: https://github.com/basecamp/solid_queue
revision: 46f2d7eda5326551d44405b48a199125ce2157c4
revision: d844a308e5c62b3d8f1942491c5433aca83dd2a9
specs:
solid_queue (0.1.0)
rails (>= 7.0.3.1)
Expand Down
4 changes: 0 additions & 4 deletions lib/active_job/queue_adapters/resque_ext.rb
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ def support_class_name_filtering?
false
end

def support_pausing_queues?
true
end

def retry_all_jobs(jobs_relation)
resque_jobs_for(jobs_relation).retry_all
end
Expand Down
4 changes: 0 additions & 4 deletions lib/active_job/queue_adapters/solid_queue_ext.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ def support_class_name_filtering?
true
end

def support_pausing_queues?
false
end

def retry_all_jobs(jobs_relation)
find_solid_queue_jobs_within(jobs_relation).each(&:retry)
end
Expand Down
2 changes: 0 additions & 2 deletions test/active_job/queue_adapters/adapter_testing/queues.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ module ActiveJob::QueueAdapters::AdapterTesting::Queues
end

test "pause and resume queues" do
skip unless ActiveJob::Base.queue_adapter.support_pausing_queues?

create_queues "queue_1", "queue_2"

queue = ApplicationJob.queues[:queue_1]
Expand Down

0 comments on commit 7f4fb35

Please sign in to comment.