Optimization: prevent empty COMMIT calls #166
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents `BEGIN COMMIT` empty database calls after each rails request if the session did not change. Don't know why the `write_session` is called in our app every request, but monkey patching using this logic prevents an empty write at the end of each request.
sikachu
requested changes
Mar 10, 2021
|
Can this be merged? |
|
any update on this? this seems to be useful. Also the store seems to record empty session on every request without valid session. Is there a way to optimise it other than overriding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents
BEGIN COMMITempty database calls after each rails request if the session did not change.Don't know why the
write_sessionis called in our app every request, but monkey patching using this logic prevents an empty write at the end of each request.