Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix ARM builds #7065

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Fix ARM builds #7065

wants to merge 2 commits into from

Commits on May 19, 2021

  1. Fix PyInstaller bundling 

    Our bundled binaries seem to have been not working for some time.

We had two separate issues:
- The `av` dependency (via `aiortc`) wasn't being properly discovered
  by PyInstaller.
  This has been fixed with a hook.
- On Linux stripping of the libraries apparently causes some corruption
  See: pypa/manylinux#119
  Therefore stripping is disabled for now.
- The gevent runtime hook would attempt to start the aio event loop. 
  This caused a warning about an already running loop.

This also fixes:
- Don't include unnecessary av libraries in the bundle
- Remove no longer used GETH_URL and SOLC_URL build args from the
  `bundle-docker` make target.
- On CI: Invoke the built binaries with `--help` as a minimal
  functionality sanity check.
    @ulope
    ulope committed May 19, 2021
    Configuration menu
    Copy the full SHA
    09ee03e View commit details
    Browse the repository at this point in the history

  2. [WIP] Fix building ARM binaries

    @ulope
    ulope committed May 19, 2021
    Configuration menu
    Copy the full SHA
    5e51f8c View commit details
    Browse the repository at this point in the history