Skip to content

Commit

Permalink
Add linting override for .js and improve Welcome page changelog forma…
Browse files Browse the repository at this point in the history
…tting
  • Loading branch information
Heliozoa committed Sep 11, 2024
1 parent e1d23ec commit 6bc732b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,11 @@ module.exports = {
"@typescript-eslint/no-unused-expressions": "off",
},
},
{
files: ["*.js"],
rules: {
"@typescript-eslint/no-require-imports": "off",
},
},
],
};
2 changes: 1 addition & 1 deletion bin/runTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ async function main() {
extensionTestsEnv,
platform,
});
} catch (err) {
} catch (_err) {
console.error("Failed to run tests");
exitCode = 1;
}
Expand Down
2 changes: 1 addition & 1 deletion bin/validateRelease.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ fi

# Welcome panel must have entry matching <h3>[X.Y.Z]</h3>
# Count the number of matches
changelogEntry=$(grep -Ec "<h3>\[$tagVersion\] - [0-9]{4}(-[0-9]{2}){2}</h3>" webview-ui/src/panels/Welcome.svelte)
changelogEntry=$(grep -Ec "<h3>$tagVersion - [0-9]{4}(-[0-9]{2}){2}</h3>" webview-ui/src/panels/Welcome.svelte)
if [[ $changelogEntry != 1 ]]
then
echo "Error: Version entry for '${tagVersion}' in the Welcome panel changelog (./webview-ui/src/panels/Welcome.svelte) is either missing or not formatted properly."
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
"eslint-check": "ESLINT_USE_FLAT_CONFIG=false eslint . --ext .js,.ts",
"postinstall": "babel node_modules/ts-results --out-dir node_modules/ts-results --plugins=@babel/plugin-transform-modules-commonjs",
"install:all": "npm install && cd backend && npm install && cd ../webview-ui && npm install",
"lint": "ESLINT_USE_FLAT_CONFIG=false eslint src --ext ts",
"lint-check": "npm run eslint-check && npm run prettier-check",
"playwright-test": "npm run webview:build && npm run webpack && xvfb-maybe playwright test",
"playwright-test-debug": "npm run webview:build && npm run webpack && xvfb-maybe playwright test --debug",
"prepare": "ts-patch install && typia patch && husky",
Expand Down
4 changes: 2 additions & 2 deletions webview-ui/src/panels/Welcome.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<!-- This list should generally contain only the last couple versions/months worth of updates -->

<div class="content_section">
<h3>3.0.4</h3>
<h3>3.0.4 - 2024-08-29</h3>
<h4>.csproj files are no longer included when submitting C# exercises</h4>
<p>
Previously, it was possible to modify and submit .csproj files which would cause
Expand All @@ -90,7 +90,7 @@
</p>
</div>
<div class="content_section">
<h3>3.0.3</h3>
<h3>3.0.3 - 2024-02-26</h3>
<h4>Fixed missing "Send solution to server" button when tests are ran successfully</h4>
<p>This button existed in the old UI but was accidentally omitted from the new one.</p>
<h4>Fixed running tests for exam exercises not working correctly</h4>
Expand Down

0 comments on commit 6bc732b

Please sign in to comment.