Support © in TrueType fonts #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalh
requested changes
Jul 2, 2022
There was a problem hiding this comment.
I don't think you tested this change properly. RF arrows characters ⯅⯆⯈⯇ (0xA2-0xA5) do not exist in font included in Dash Faction (modified Opti Edgar Extended). Specified codes map to completely different characters (not arrows). You can see that if you open ttf file included in dashfaction.vpp or in resources/fonts directory. Your change in ranges must be joined with a proper change to ttf fonts. Only the '©' symbol (0xA9) exists in ttf with a proper code so it could be added without changing fonts.
You should also merge new ranges with already existing ones,
Also please update the CHANGELOG.
is-this-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.