Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NavigationMenu] Remove unsuported disableOutsidePointerEvents prop #2741

Merged
merged 3 commits into from
Feb 29, 2024
Merged

[NavigationMenu] Remove unsuported disableOutsidePointerEvents prop #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dc42b1
[NavigationMenu] Remove unsuported `disableOutsidePointerEvents` prop
benoitgrelard Feb 29, 2024
3c827c0
Trigger status?
benoitgrelard Feb 29, 2024
69e4d31
Revert "Trigger status?"
benoitgrelard Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .yarn/versions/e97b6ff3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
releases:
"@radix-ui/react-navigation-menu": patch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is technically breaking? not sure how much it matters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, though I would think probably rare, and we can always call it out in the changelog.


declined:
- primitives
3 changes: 2 additions & 1 deletion packages/react/navigation-menu/src/NavigationMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ interface NavigationMenuContentImplPrivateProps {
onRootContentClose(): void;
}
interface NavigationMenuContentImplProps
extends Omit<DismissableLayerProps, 'onDismiss'>,
extends Omit<DismissableLayerProps, 'onDismiss' | 'disableOutsidePointerEvents'>,
NavigationMenuContentImplPrivateProps {}

const NavigationMenuContentImpl = React.forwardRef<
Expand Down Expand Up @@ -922,6 +922,7 @@ const NavigationMenuContentImpl = React.forwardRef<
data-orientation={context.orientation}
{...contentProps}
ref={composedRefs}
disableOutsidePointerEvents={false}
onDismiss={() => {
const rootContentDismissEvent = new Event(ROOT_CONTENT_DISMISS, {
bubbles: true,
Expand Down
Loading