Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MenuSubContent] Expose side prop #2556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[MenuSubContent] Expose side prop #2556

wants to merge 2 commits into from

Conversation

drKnoxy
Copy link

@drKnoxy drKnoxy commented Nov 30, 2023

Description

Exposing the side prop on the MenuSubContent component.
Currently this just takes the side from the dir.

@recurrence
Copy link

Wow I had just opened a feature request for this, what timing :)

@chaance
Copy link
Member

chaance commented Sep 26, 2024

@drKnoxy Do you mind running yarn version check --interactive so this gets captured in our changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard Awaiting requested review from benoitgrelard

@andy-hook andy-hook Awaiting requested review from andy-hook

@StephenHaney StephenHaney Awaiting requested review from StephenHaney StephenHaney is a code owner

@vladmoroz vladmoroz Awaiting requested review from vladmoroz vladmoroz is a code owner

@lucasmotta lucasmotta Awaiting requested review from lucasmotta lucasmotta is a code owner

@hadihallak hadihallak Awaiting requested review from hadihallak hadihallak is a code owner

@chaance chaance Awaiting requested review from chaance chaance is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drKnoxy @recurrence @chaance