Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portal] Make container type consistent with ReactDOM.createPortal #2329

Merged
merged 3 commits into from
Sep 27, 2024
Merged

[Portal] Make container type consistent with ReactDOM.createPortal #2329

merged 3 commits into from
Sep 27, 2024

Conversation

maltoze
Copy link
Contributor

@maltoze maltoze commented Aug 9, 2023 •
edited
Loading

Description

container can be a ShadowRoot

export function createPortal(children: ReactNode, container: Element | DocumentFragment, key?: null | string): ReactPortal;

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/4067c24b2abc0a5d30c53f37fb2472e6678bf23e/types/react-dom/index.d.ts#L28

@chaance chaance merged commit 4b3b969 into radix-ui:main Sep 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaance chaance chaance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltoze @chaance