fence-1145-make-the-autocomplete-function-take-a-countrycode-param #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeier
reviewed
Aug 4, 2023
| var callbackStatus: Radar.RadarStatus? = null | ||
| var callbackAddresses: Array<RadarAddress>? = null | ||
|
|
||
| Radar.autocomplete("brooklyn roasting", country="UK", expandUnits = true) { status, addresses -> |
There was a problem hiding this comment.
Nice testing the named params like this -- why don't we also test with named param for countryCode as well
lmeier
requested changes
Aug 7, 2023
Comment on lines
3149
to
3160
| /** | ||
| * Autocompletes partial addresses and place names, sorted by relevance. | ||
| * | ||
| * @see [](https://radar.com/documentation/api#autocomplete) | ||
| * | ||
| * @param[query] The partial address or place name to autocomplete. | ||
| * @param[near] A location for the search. | ||
| * @param[layers] Optional layer filters. | ||
| * @param[limit] The max number of addresses to return. A number between 1 and 100. | ||
| * @param[country] An optional country filter. A string, the unique 2-letter country code. | ||
| * @param[callback] A callback. | ||
| */ |
There was a problem hiding this comment.
Add a note that this version of the function is deprecated, and to prefer the above.
| var callbackStatus: Radar.RadarStatus? = null | ||
| var callbackAddresses: Array<RadarAddress>? = null | ||
|
|
||
| Radar.autocomplete("brooklyn roasting", near, null, 10, "US",true) { status, addresses -> |
| } | ||
|
|
||
| /** | ||
| * Autocompletes partial addresses and place names, sorted by relevance. |
There was a problem hiding this comment.
Add a note that this version of the function is deprecated, and to prefer the one above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.