Add options scope to junitreporter #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Oct 17, 2023
NEWS.md
Outdated
| @@ -54,6 +54,9 @@ | |||
|
|
|||
| * `test_file()` gains a `desc` argument which allows you to run a single | |||
| test from a file (#1776). | |||
|
|
|||
| * `JunitReporter()` now uses ensures numeric values are saved the xml file | |||
There was a problem hiding this comment.
Can you please put this under the development version heading?
There was a problem hiding this comment.
I'm sorry, my bad, didn't spot that there are 2 versions back to back. Want me to copy the same subsection structure (## Lifecycle changes, ## New features etc.) or just put it under the development version and that's it?
There was a problem hiding this comment.
No, just copy the bullet. We add the subsections as part of the release process.
R/reporter-junit.R
Outdated
| xml2::xml_attr(self$suite, "tests") <- as.character(self$tests) | ||
| xml2::xml_attr(self$suite, "skipped") <- as.character(self$skipped) | ||
| xml2::xml_attr(self$suite, "failures") <- as.character(self$failures) | ||
| xml2::xml_attr(self$suite, "errors") <- as.character(self$errors) | ||
| #jenkins junit plugin requires time has at most 3 digits | ||
| xml2::xml_attr(self$suite, "time") <- as.character(round(self$suite_time, 3)) | ||
|
|
||
There was a problem hiding this comment.
Could you please get rid of these spurious whitespace changes?
R/reporter-junit.R
Outdated
Comment on lines
88
to
89
| # Make sure that any options posed by particular tests environments | ||
| # will not interfere with how values are saved to the file |
There was a problem hiding this comment.
Suggested change
| # Make sure that any options posed by particular tests environments | |
| # will not interfere with how values are saved to the file | |
| # Always uses . as decimal place in output regardless of options set in test |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1660
According to @hadley's suggestions, I just enforced the decimal operator as an option scoped to the entire function. With that change, JUnit file should always be valid regardless of the decimal separator option used in the test.