Align with withr::local_language() from dev withr
#1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirming that this fixes my problems with dev withr: r-dbi/RMariaDB@9e1f5d1.
I wonder why testthat's own tests fail now. |
|
Maybe you need to adjust the tests like this? r-lib/withr@08619ef |
|
Tried a moonshot, but could you please take this on (fixing tests if needed, NEWS, ...)? |
lionel-
reviewed
Jan 9, 2024
Co-authored-by: Lionel Henry <[email protected]>
|
@lionel- can you take another look at this please? |
lionel-
approved these changes
Feb 13, 2024
hadley
reviewed
Feb 13, 2024
| @@ -133,8 +133,10 @@ local_reproducible_output <- function(width = 80, | |||
| .local_envir = .env | |||
| ) | |||
|
|
|||
| if (isTRUE(capabilities("NLS")) && Sys.getenv("LANG") != "C") { | |||
| withr::local_language(lang, .local_envir = .env) | |||
| if (isTRUE(capabilities("NLS"))) { | |||
There was a problem hiding this comment.
Should we also bump version in DESCRIPTION?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise tests show warnings for me.