Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance deprecations #1874

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Advance deprecations #1874

merged 2 commits into from
Sep 29, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Sep 29, 2023

No description provided.

Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a test for wrap being deprecated in test_dir() if you want, but it looks right

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Davis Vaughan <[email protected]>
@hadley
Copy link
Member Author

hadley commented Sep 29, 2023

It didn't have one for being deprecated, so I figured it doesn't need one for being defunct 😀

@hadley hadley merged commit 956f4f6 into main Sep 29, 2023
12 checks passed
@hadley hadley deleted the advance-deprecations branch September 29, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants