Drop obsolete references to R3.5 (#1881)

* Drop skip for unsupported R3.5 * Remove conditional eval in vignette too * trailing comma
r-lib · Nov 29, 2023 · f51a592 · f51a592
1 parent 11b62e0
commit f51a592
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/tests/testthat/test-expect-known.R b/tests/testthat/test-expect-known.R
@@ -105,7 +105,6 @@ test_that("equal_to_ref does not overwrite existing", {
 })
 
 test_that("serializes to version 2 by default", {
-  skip_if(getRversion() < "3.5")
   tmp_rds <- tempfile(fileext = ".rds")
   on.exit(unlink(tmp_rds))
 
@@ -118,7 +117,6 @@ test_that("serializes to version 2 by default", {
 })
 
 test_that("version 3 is possible", {
-  skip_if(getRversion() < "3.5")
   tmp_rds <- tempfile(fileext = ".rds")
   on.exit(unlink(tmp_rds))
 

diff --git a/vignettes/test-fixtures.Rmd b/vignettes/test-fixtures.Rmd
@@ -10,9 +10,7 @@ vignette: >
 ```{r, include = FALSE}
 knitr::opts_chunk$set(
   collapse = TRUE,
-  comment = "#>",
-  # Since after is not available prior to 3.5
-  eval = getRversion() >= "3.5"
+  comment = "#>"
 )
 ```