Transformation suffixes to prefixes #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are up for it I'd like to rename |
|
Sure. Just to clarify, we then should end up with the |
|
exactly. Further, the auxiliary functions also needs renaming + alias (e.g. |
|
I'm going to make a new PR for that, as git merge just wipes all of this PRs changes and I'm in no mood to manually go through every change. I'll start with a clean slate |
|
Closing this in favour of #410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #390.
Briefly, it renames all
*_transfunctions totrans_*functions, while keeping the suffixed versions as aliases.The
as.trans()function first tries the prefixed version, and when unavailable, tries the suffixed version for backward compatibility.