Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3 generics for colSums, rowSums, and their integer64 implementations #86

Merged
merged 14 commits into from
Oct 20, 2024
Merged

Add S3 generics for colSums, rowSums, and their integer64 implementations #86

merged 14 commits into from
Oct 20, 2024

Conversation

MichaelChirico
Copy link
Collaborator

Closes #38

@vlulla
Copy link

vlulla commented Oct 17, 2024

Would this work for higher dimension arrays too? It appears that base::colSums/base::rowSums work for arrays. I have not used rowSums/colSums with higher dimension arrays but just wanted to bring this to your attention. Thanks for working on this.

@MichaelChirico
Copy link
Collaborator Author

thanks! I'm aware and testing against arrays :)

doing so led to this R patch 🚀

r-devel/r-svn@ad4b20a

@MichaelChirico MichaelChirico mentioned this pull request Oct 20, 2024
Open
@MichaelChirico MichaelChirico mentioned this pull request Oct 20, 2024
Merged
@MichaelChirico MichaelChirico merged commit 1a9e50d into master Oct 20, 2024
9 checks passed
@MichaelChirico MichaelChirico deleted the cr-sum-methods branch October 20, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

colSums/rowSums do not work when as.integer64(NA) is present in data.table
2 participants
@MichaelChirico @vlulla