Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not submit] check on all claimed R versions #109

Closed
wants to merge 6 commits into from

Conversation

MichaelChirico
Copy link
Collaborator

No description provided.

@MichaelChirico MichaelChirico mentioned this pull request Oct 22, 2024
7 tasks
@hadley
Copy link
Member

hadley commented Oct 22, 2024

Out of interest, what's your goal here?

@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Oct 22, 2024

I think if I claim Depends: R (>=3.4.0), ideally the package should work as intended on those versions.

I won't be able to get CI to say anything about 3.4.0/3.5.0 because {testthat} won't install there, but everything else can give useful data.

For 3.4.0, I got the codespace working & tested the package to my satisfaction: https://github.com/r-lib/bit64/tree/main/.devcontainer/r-340.

@MichaelChirico
Copy link
Collaborator Author

#111 is a good example.

@MichaelChirico
Copy link
Collaborator Author

OK, as of now all of the failures are either (1) #111 or (2) due to R itself being too old. There's also one failure for {os: macos-13, r: '4.3.2'}, looks spurious/flaky.

@hadley
Copy link
Member

hadley commented Oct 22, 2024

Hmmm, interesting. Our position is that if you're using (e.g.) 4.2.x, you should be using the latest patch version.

FWIW testthat is likely to bump its requirement to 4.0.0 in the next release, so you might want to match that. (i.e. follow https://www.tidyverse.org/blog/2019/04/r-version-support/)

@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Oct 22, 2024

In this case all of 4.2.x are affected (fixed the issue title). I wouldn't bend over backwards to fix something for a specific R version, but being able to document known issues+workarounds is good.

Being able to test all of these platforms+versions so easily, I want to take advantage of it. Also note that this is only a release procedure, I don't want to test so broadly on every commit.

@MichaelChirico
Copy link
Collaborator Author

OK, passing on all testable versions now.

@MichaelChirico MichaelChirico deleted the test-all-r branch October 22, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants