-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not submit] check on all claimed R versions #109
Conversation
Out of interest, what's your goal here? |
I think if I claim I won't be able to get CI to say anything about 3.4.0/3.5.0 because {testthat} won't install there, but everything else can give useful data. For 3.4.0, I got the codespace working & tested the package to my satisfaction: https://github.com/r-lib/bit64/tree/main/.devcontainer/r-340. |
#111 is a good example. |
OK, as of now all of the failures are either (1) #111 or (2) due to R itself being too old. There's also one failure for |
Hmmm, interesting. Our position is that if you're using (e.g.) 4.2.x, you should be using the latest patch version. FWIW testthat is likely to bump its requirement to 4.0.0 in the next release, so you might want to match that. (i.e. follow https://www.tidyverse.org/blog/2019/04/r-version-support/) |
In this case all of 4.2.x are affected (fixed the issue title). I wouldn't bend over backwards to fix something for a specific R version, but being able to document known issues+workarounds is good. Being able to test all of these platforms+versions so easily, I want to take advantage of it. Also note that this is only a release procedure, I don't want to test so broadly on every commit. |
OK, passing on all testable versions now. |
No description provided.