Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary use of circuit.propagatos #226

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Dec 18, 2023

QubitCircuit.compute_unitary() is faster after the refactoring and saves memory.

`QubitCircuit.compute_unitary()` is faster and saves memory.
@BoxiLi BoxiLi added this to the qutip-qip-0.3.1 milestone Dec 18, 2023
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also wondering if we should add a couple of circuit benchmarks to the qutip-benchmarks repository?

@BoxiLi
Copy link
Member Author

BoxiLi commented Feb 22, 2024

Yes, that would be nice, We haven't been focused that much on circuit simulation efficiency so far. But if there are people eager to create it, it would surely be awesome.

@BoxiLi BoxiLi merged commit d37098b into qutip:master Feb 22, 2024
14 checks passed
BoxiLi added a commit to BoxiLi/qutip-qip that referenced this pull request Apr 20, 2024
`QubitCircuit.compute_unitary()` is faster and saves memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants