Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Dockerfile from debian to buster #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Edit Dockerfile from debian to buster #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM debian:jessie
FROM debian:buster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about debian:buster-slim instead?

Copy link
Contributor

@ahmedre ahmedre Apr 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or bookworm-slim even?


MAINTAINER Hossam Hammady <[email protected]>

Expand Down Expand Up @@ -35,6 +35,8 @@ RUN cd /app && \
make && \
make install

RUN find /app -type f -name '*.pl' -exec sed -i 's/\r$//' {} \;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change the script/generate.pl directly just remove the \r instead of running this every time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually not seeing a \r here - i'll look into this some more.


RUN sed -i 's/localhost/mysql/' /app/config/database.yaml

CMD /app/script/generate.pl help