Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_models.py #940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianhou0208
Copy link
Contributor

Description

New decoder was added in #926, but I found that UPerNet & DeepLabV3Plus missed some tests.

This PR fixes some bugs and ensures that each decoder has been tested.

Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Comment on lines -32 to -37
smp.UPerNet,
]:
sample = torch.ones([1, 3, 64, 64])
elif model_class == smp.PAN:
elif model_class == smp.PAN or model_class == smp.UPerNet:
sample = torch.ones([2, 3, 256, 256])
elif model_class == smp.DeepLabV3:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why UPerNet requires a bigger input size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants