Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: Add annotations to clair deployment manifest template #1858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

syed
Copy link
Contributor

@syed syed commented Sep 15, 2023

This can be used to restart clair in prod without doing a dummy image build

@syed syed requested a review from a team as a code owner September 15, 2023 15:42
@syed syed requested review from hdonnay and removed request for a team September 15, 2023 15:42
@syed syed force-pushed the main branch 2 times, most recently from b2b7b5b to b0865c4 Compare September 15, 2023 16:58
@hdonnay
Copy link
Member

hdonnay commented Sep 15, 2023

Wouldn't this require new commits to this repository? Why can't something like kubectl rollout restart be used?

@crozzy
Copy link
Collaborator

crozzy commented Sep 21, 2023

Nice, this is definitely something we'd want. Is there not a way to do this directly in app-interface?

The only thing I'd say about the PR itseld is; is there an advantage to being about to override the annotation key? That seems like something that we'd never update. Thanks!

This can be used to restart clair in prod without doing a dummy image build

Signed-off-by: Syed <[email protected]>
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crozzy what do you want to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants