-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): add role="list" to QList (fix: #17439) #17441
fix(ui): add role="list" to QList (fix: #17439) #17441
Conversation
UI Tests Results 1 files 98 suites 38s ⏱️ Results for commit db8e1ca. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nicely done. I have some small suggestions.
Co-authored-by: Yusuf Kandemir <[email protected]>
Co-authored-by: Yusuf Kandemir <[email protected]>
Thanks for contributing, will be available in the next |
I also added some tests for the QList component. The QItem
role="listitem"
should be similarly conditional when usingli
as a tag, because then the listitem role is not necessary. But that could be a next PR.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: