Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Adds docker-compose to quasar default template. #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codingfriend1
Copy link

@codingfriend1 codingfriend1 commented Aug 20, 2017

Adds an optional ability to develop your app in a docker container using the default 8080 port. quasar dev --play isn't working in this configuration, you must manually add your computers ip port in the play app. Some people prefer to do their development in containers to keep things isolated and portable, so other developers running the project don't have to install cordova, quasar-cli, or node.

NOTE: This is not a final pull request, this is a sample

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@smolinari
Copy link
Contributor

Have you seen this?

https://github.com/quasarframework/quasar-docker

Which reminds me, I need to update the containers now that 0.14 is out of beta.

Scott

@codingfriend1
Copy link
Author

Cool, didn't see this! Thanks for sharing!

@lkiii
Copy link

lkiii commented Sep 12, 2018

@smolinari what happened to https://github.com/quasarframework/quasar-docker I am trying to set up something similar without success. It would be really useful to review what you had in that repository.

@smolinari
Copy link
Contributor

@lkiii - The docker stuff has been put on the back burner. I need to speak to Razvan about it, but I'd personally like to get it going again for 1.0, which is planned, I believe at the latest, for the end of the year.

Scott

@lkiii
Copy link

lkiii commented Sep 13, 2018

@lkiii - The docker stuff has been put on the back burner. I need to speak to Razvan about it, but I'd personally like to get it going again for 1.0, which is planned, I believe at the latest, for the end of the year.

Scott

thank you for the response, maybe I could help with it? I would love to see it working on docker. I had a goal not to install node on my machine only docker, but quasar made me do it.

Also maybe you have a backup of the https://github.com/quasarframework/quasar-docker I would be really happy to look at it.

@smolinari
Copy link
Contributor

@lkiii

Can you get onto Discord? We can PM there about this? For sure we can collaborate. In fact, that would be great!

Scott

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants