Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow use publicPath #125

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

alexdee2007
Copy link

@alexdee2007 alexdee2007 commented Nov 22, 2022

This change allows the public path of your app specified in property publicPath in quasar.conf.js
Closes #123

This change allows the public path of your app specified in property `publicPath` in quasar.conf.js
@nucle
Copy link

nucle commented Nov 28, 2022

Thank you I will inform @hawkeye64 and when everything is ok i merge it
BR

@alexdee2007
Copy link
Author

Any update on this?

@hawkeye64
Copy link
Member

Thank you I will inform @hawkeye64 and when everything is ok i merge it BR

Have you had a chance to test this?

@daniel-fahl
Copy link

I'm afraid this solution might lead to issues when using vue router in history mode, as the relative path would include vue pages instead of the public directory. I've tried to solve this in #132 by passing the publicPath config value through the boot file to the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants