fix(brand): Fix and improve Bootstrap variable handling #11168
Merged
+16
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing
g
flag in the regex that sanitizesbrand.color.palette
names for use in Sass and CSS variables.Drop
gray
andgray-dark
from Bootstrap color variables list. These appear in Bootstrap's$colors
map but are derived from the gray color palette, and are not top-level color Sass variables.Drop the
brand.defaults.bootstrap.version
check. On second thought, I imagine Quarto plans to support at most one version of Bootstrap at a time. You might want to throw a warning if someone asks for BS 5 after Quarto moves to BS 6 (in some distant future), but we don't need the version check now.Furthermore, in the
defaults
layer there's very little risk in setting Sass variables across Boostrap versions. Since they're all defined with${var}: {value} !default;
, either they'll be used by Bootstrap or they won't. So the chance of breakage is small.