[1.5.z] Backport 23/10/2024 #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of linux we propagating all build arguments which also contains `maven.repo.local`. This is not case on windows where we getting only specific set of them (starts with Quarkus). When quarkus-qe#1359 was introducedThe build start separatly using maven. But when provided path to local maven repo was set as cmd argument and the artifact is not public, causing the windows failing the build of app with that forced artifact. (cherry picked from commit afdcab9)
(cherry picked from commit 8103989)
(cherry picked from commit a4e5ed0)
(cherry picked from commit 528f205)
| @@ -312,13 +314,15 @@ public static Model getPom(QuarkusCliRestService app) throws XmlPullParserExcept | |||
| public static Model getPom(QuarkusCliRestService app, String subdir) throws IOException, XmlPullParserException { | |||
| File pomfile = app.getFileFromApplication(subdir, POM_FILE); | |||
| MavenXpp3Reader mavenReader = new MavenXpp3Reader(); | |||
| XmlStreamReader streamReader = new XmlStreamReader(pomfile); | |||
| return mavenReader.read(streamReader); | |||
| try (XmlStreamReader streamReader = new XmlStreamReader(pomfile)) { | |||
There was a problem hiding this comment.
Interesting, I might have a MavenXpp3Reader were I made mistake. I have to revise what I do.
michalvavrik
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport contains:
maven.repo.localon windows machine #1373Please check the relevant options
run testsphrase in comment)Checklist: