Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use periodic Quarkus snapshot build in PR workflow to reduce GitHub actions execution time #1371

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Use periodic Quarkus snapshot build in PR workflow to reduce GitHub actions execution time #1371

merged 1 commit into from
Oct 17, 2024

Conversation

michalvavrik
Copy link
Member

Summary

According to the https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#using-snapshots there is daily build published to the Sonatype snapshots repository, so let's use it and reduce PR CI execution time.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

I don't understand MySQL failures, let's wait for next daily build to see if this is related to this PR or not.

@michalvavrik
Copy link
Member Author

I"ve retriggered CI because daily build is green, this is strange.

@michalvavrik michalvavrik marked this pull request as draft October 16, 2024 09:26
@michalvavrik michalvavrik force-pushed the feature/use-published-periodic-999-snapshot-build branch from a6dcd04 to de40f21 Compare October 16, 2024 21:12
@michalvavrik michalvavrik force-pushed the feature/use-published-periodic-999-snapshot-build branch from de40f21 to da35d63 Compare October 16, 2024 21:29
@michalvavrik michalvavrik marked this pull request as ready for review October 16, 2024 22:25
rsvoboda
rsvoboda approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rsvoboda rsvoboda merged commit 288e1f2 into quarkus-qe:main Oct 17, 2024
7 checks passed
@michalvavrik michalvavrik deleted the feature/use-published-periodic-999-snapshot-build branch October 17, 2024 14:13
@jedla97 jedla97 mentioned this pull request Oct 22, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @rsvoboda