-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liveness probe for GraphQL client and additional colors for monthly stats #60
Conversation
fedinskiy
commented
Jul 26, 2024
•
edited
Loading
edited
- Adds a liveness probe to restart the app if GraphQL client is stuck
- Adds more fixed colors for monthly stats, so certain @fedinskiy will not be shown in 5 different ways on the same page :)
Monthly stats are shown with dedicated colors for the first 7 team members from `activity.logins` variable. Now there are 8 team members, so the last one in the list (fedinskiy) receives a different random color for every graph on the same page. This commit adds two additional colors, one for fedinskiy and another for a potential future team member.
Please do not merge, until we're sure, that the liveness probe works as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very creative and a good workaround. I didn't look closer into created GraphQL client issue as I trust you there. Please confirm when you verified this with actual deployment.
yeah, but please fix PR title. |
Do we have a way to findout how many times was the pod restarted in e.g. last 4 weeks? |
@rsvoboda if this solution works, then we will be able to see number of restarts on "workloads/pods/" section in OCP administrator view. |
@michalvavrik @rsvoboda the restart worked as expected: https://console-openshift-console.apps.gpc.ocp-hub.prod.psi.redhat.com/k8s/ns/quarkus-qe--runtime-int/core~v1~Pod. Do you want to take a second look or this can be merged? |
No need, going to merge it now |