Liveness probe for GraphQL client and additional colors for monthly stats #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fedinskiy
commented
Jul 26, 2024
•
fedinskiy
commented
- Adds a liveness probe to restart the app if GraphQL client is stuck
- Adds more fixed colors for monthly stats, so certain @fedinskiy will not be shown in 5 different ways on the same page :)
Monthly stats are shown with dedicated colors for the first 7 team members from `activity.logins` variable. Now there are 8 team members, so the last one in the list (fedinskiy) receives a different random color for every graph on the same page. This commit adds two additional colors, one for fedinskiy and another for a potential future team member.
|
Please do not merge, until we're sure, that the liveness probe works as expected |
michalvavrik
approved these changes
Jul 26, 2024
|
yeah, but please fix PR title. |
fedinskiy
changed the title
|
Do we have a way to findout how many times was the pod restarted in e.g. last 4 weeks? |
|
@rsvoboda if this solution works, then we will be able to see number of restarts on "workloads/pods/" section in OCP administrator view. |
|
@michalvavrik @rsvoboda the restart worked as expected: https://console-openshift-console.apps.gpc.ocp-hub.prod.psi.redhat.com/k8s/ns/quarkus-qe--runtime-int/core~v1~Pod. Do you want to take a second look or this can be merged? |
|
No need, going to merge it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.