-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor integration tests #80
Conversation
Hi Pablo, thank you for this fantastic contribution ! Which is the main reason behind the two tests without smallrye ? Are you testing that the same happen ? |
In my opinion, in the future, we could remove the scenario @masini fyi |
Build job has been decopled into three jobs 'validate-format', 'linux-build-jvm' and 'linux-build-native' The last two jobs depends on 'validate-format', so once the project is validated, we will run both jobs in parallel.
@masini I have rebased my branch with the latest changes. Do you want me to change something? |
@masini I have removed the "vanilla" coverage because I think that was a conflict point. |
7d985af
to
0318763
Compare
@@ -1,8 +1,8 @@ | |||
package io.quarkiverse.hivemqclient; | |||
|
|||
import io.quarkus.test.junit.NativeImageTest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, any reason to not go native?
}); | ||
source.open(); | ||
Thread.sleep(15 * 1000L); | ||
} catch (InterruptedException ignored) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I understand this correctly. Shouldn't we fail in this exception?
priceCount.incrementAndGet(); | ||
}); | ||
source.open(); | ||
Thread.sleep(15 * 1000L); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use CountDownLatch to avoid this sleep?
Build
GH actions into tree jobsvalidate-format
,linux-build-jvm
andlinux-build-native
integration-tests
folderA new scenario with a vanilla implementation has been added to theintegration-tests
folderintegration-tests
folderREADME.md
cc @masini @codepitbull 🙏