Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLF4J-165 Handling of unknown (custom) priorities is different than i… #277

Open
wants to merge 1 commit into
base: 1.7-maintenance
Choose a base branch
from

Conversation

DavesMan
Copy link

…n log4j (throwing an IllegalStateException than using the effective level of the given Priority / Level / Category)

…n log4j (throwing an IllegalStateException than using the effective level of the given Priority / Level / Category)

Signed-off-by: DavesMan <[email protected]>
@@ -323,7 +323,8 @@ private int priorityToLevelInt(Priority p) {
case Priority.FATAL_INT:
return LocationAwareLogger.ERROR_INT;
default:
throw new IllegalStateException("Unknown Priority " + p);
slf4jLogger.warn("Unknown Priority " + p);
return LocationAwareLogger.TRACE_INT;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original JIRA suggests DEBUG level. TRACE will be visible everywhere. So feel free to change the corrected logging level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant