Fix PE loader to recursivly import symbols and call DllMain #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the issues with the PE loader:
Calling DllMain is imperative, in order to initialize constructors (e.g. c++ static initializers and other library init stuff).
The idea proposed by #801 with delaying loading the DLLs until the first symbol is called, raises the question of when to call DllMain(). In this PR I load the DLLs recursively at startup, and also call DLLmain, but I skip the virtual DLLs in the hope that it is faster than #801. Also, by skip loading the virtual DLLs I hope that we can avoid copying the api-*.dlls entirely (which caused build problems in #886).
Unfortunately I was not able to run the testcases on my machine. Can you run the workflow?
Credits go to @crass (#886). I've copied his idea with the
init_import
method.Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing