-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test removed recycle pool warns, no longer errors #345
Open
Oddant1
wants to merge
6
commits into
qiime2:dev
Choose a base branch
from
Oddant1:qiime2-issue-787
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oddant1
added
the
stat:blocked
This cannot be resolved until something else has changed.
label
Sep 24, 2024
|
colinvwood
approved these changes
Oct 3, 2024
colinvwood
added
stat:DO-NOT-MERGE
Please do not merge this until this label has been removed.
and removed
stat:blocked
This cannot be resolved until something else has changed.
labels
Oct 4, 2024
colinvwood
changed the title
Qiime2 issue 787
Test removed recycle pool no warns, no longer errors
Oct 4, 2024
colinvwood
changed the title
Test removed recycle pool no warns, no longer errors
Test removed recycle pool warns, no longer errors
Oct 4, 2024
Unsure if this is still failing because of CI or because of a problem with the test @Oddant1 |
@colinvwood It's failing because it's pulling an old version of the framework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qiime2/qiime2#787