Allow parallel optimizations in Qdrant after uploading #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
max_optimization_threadsparameter is currently configured incorrectly after uploading, and this does not allow parallel optimizations.This PR sets it to a high value so that we do use parallel optimizations as it'll likely result in better results. Note that setting such high limit is fine, because in practice we're still limited by CPU budget. We cannot set it back to
nullthrough this API.On my machine with 24 CPUs I now see 3 parallel optimizations, rather than just 1. The indexing time is more than 2 times quicker.
Am I correct that the benchmark machine we used for the public results does not have more than 8 CPU cores? If we did have more cores, we should probably redo the benchmarks.