General improvements: extended exposed latency metrics and allowed for filtering benchmark runs by client count. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more metadata. Allowed to filter benchmark runs by client count
KShivendu
reviewed
Mar 7, 2024
engine/base_client/client.py
Outdated
Comment on lines
113
to
121
| ef = "default" | ||
| if "search_params" in search_params: | ||
| ef = search_params["search_params"].get("ef", "default") | ||
| client_count = search_params.get("parallel", 1) | ||
| filter_client_count = len(parallels) > 0 | ||
| if filter_client_count and (client_count not in parallels): | ||
| print(f"\tSkipping ef runtime: {ef}; #clients {client_count}") | ||
| continue | ||
| print(f"\tRunning ef runtime: {ef}; #clients {client_count}") |
There was a problem hiding this comment.
Could you please explain what are you trying to do here?
There was a problem hiding this comment.
this is to allow running specific client configs. The rest is just extra logging.
Co-authored-by: Kumar Shivendu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds small changes that we're already using: