Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow maxquant data containing the 'combined' subfolder #129

Merged
merged 3 commits into from
Nov 9, 2023
Merged

allow maxquant data containing the 'combined' subfolder #129

merged 3 commits into from
Nov 9, 2023

Conversation

wow-such-code
Copy link
Member

No description provided.

@wow-such-code wow-such-code requested a review from a team as a code owner November 9, 2023 14:47
Steffengreiner
Steffengreiner requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Steffengreiner Steffengreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the print from the test otherwise this looks good! Nice Catch 👀

src/test/groovy/life/qbic/utils/MaxQuantParserSpec.groovy Outdated Show resolved Hide resolved
Steffengreiner
Steffengreiner approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Steffengreiner Steffengreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@wow-such-code wow-such-code merged commit aba60af into development Nov 9, 2023
4 checks passed
@wow-such-code wow-such-code mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steffengreiner Steffengreiner Steffengreiner approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wow-such-code @Steffengreiner