Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fill structure with content #3

Merged
merged 8 commits into from
Oct 17, 2024
Merged

fill structure with content #3

merged 8 commits into from
Oct 17, 2024

Conversation

aeimer
Copy link
Collaborator

@aeimer aeimer commented Oct 16, 2024

No description provided.

@aeimer aeimer self-assigned this Oct 16, 2024
@aeimer aeimer marked this pull request as ready for review October 16, 2024 11:59
@aeimer aeimer requested a review from alex0ptr October 16, 2024 11:59
@alex0ptr
Copy link
Collaborator

Pre-Commit is broken, because vale is broken.
We should also improve the taskfile, as it does not install all dependencies immedieately. -> I'm doing a lightning talk soon and plan to use this file as an example.
ADRs are not in Arc42 section. -> Fix later.

LGTM atm.

@alex0ptr alex0ptr merged commit 0e5c0f1 into main Oct 17, 2024
0 of 2 checks passed
@aeimer aeimer deleted the feat/fill-structure-with-content branch October 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex0ptr alex0ptr Awaiting requested review from alex0ptr

Assignees

@aeimer aeimer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeimer @alex0ptr