Fix Kineto Stress Test #971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The Kineto Stress test was failing for two reasons: 1) In the test itself, we did not set the converter for the TSC timestamp, making all values out of range 2) In Kineto itself there was a bug regarding child profilers. When these profilers are set their spans are set to all 0. However, when we set the record start in Kineto we use the start span of the CPU trace to get the start of the trace itself. In the future we should probably decouple these things but for now I added an edge case to ensure that the profile is not malformed. Reviewed By: aaronenyeshi Differential Revision: D60415474
|
This pull request was exported from Phabricator. Differential Revision: D60415474 |
|
This pull request has been merged in 18606c9. |
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 6, 2024
Summary: Pull Request resolved: pytorch#971 The Kineto Stress test was failing for two reasons: 1) In the test itself, we did not set the converter for the TSC timestamp, making all values out of range 2) In Kineto itself there was a bug regarding child profilers. When these profilers are set their spans are set to all 0. However, when we set the record start in Kineto we use the start span of the CPU trace to get the start of the trace itself. In the future we should probably decouple these things but for now I added an edge case to ensure that the profile is not malformed. Reviewed By: aaronenyeshi Differential Revision: D60415474 fbshipit-source-id: e7b268aa0d41532448a28e1c1b4fe2ba81fda8da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Kineto Stress test was failing for two reasons:
In the test itself, we did not set the converter for the TSC timestamp, making all values out of range
In Kineto itself there was a bug regarding child profilers. When these profilers are set their spans are set to all 0. However, when we set the record start in Kineto we use the start span of the CPU trace to get the start of the trace itself. In the future we should probably decouple these things but for now I added an edge case to ensure that the profile is not malformed.
Reviewed By: aaronenyeshi
Differential Revision: D60415474